NonceHolder Tests #176
Merged
NonceHolder Tests #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neotheprogramist
requested review from
vladbochok and
StanislavBreadless
as code owners
AntonD3
reviewed
Feb 12, 2024
AntonD3
requested changes
Feb 12, 2024
There was a problem hiding this comment.
Left a few comments, and separately want to ask you if you can take a look at how the tests depend on the previous state. Currently, it looks like it's not possible to run the tests twice without the test node rebooting, and test cases depend on each other. So, can you please, think about fixing that?
matzayonc
force-pushed
the
3-test-nonceholder
branch
from
2862ed6
to
b2ca7c3
Compare
AntonD3
reviewed
Mar 13, 2024
matzayonc
force-pushed
the
3-test-nonceholder
branch
from
d2e86b2
to
df48665
Compare
AntonD3
reviewed
Apr 10, 2024
AntonD3
reviewed
Apr 10, 2024
matzayonc
force-pushed
the
3-test-nonceholder
branch
from
4b67182
to
d97d247
Compare
AntonD3
reviewed
May 6, 2024
AntonD3
reviewed
May 6, 2024
AntonD3
approved these changes
May 16, 2024
Yberjon
pushed a commit
to neotheprogramist/era-contracts
that referenced
this pull request
Aug 12, 2024
Co-authored-by: Uacias <filgum0326@gmail.com> Co-authored-by: Mateusz Zając <matzayonc@gmail.com> Co-authored-by: Mateusz Zając <60236390+matzayonc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.